HappenLee commented on code in PR #9157:
URL: https://github.com/apache/incubator-doris/pull/9157#discussion_r858183115
##########
be/src/olap/memtable.h:
##########
@@ -96,25 +95,19 @@ class MemTable {
}
}
- RowCursorCell cell(vectorized::MutableBlock* block, int cid){
- StringRef ref =
block->mutable_columns()[cid]->get_data_at(_row_pos);
- bool is_null = block->mutable_columns()[cid]->is_null_at(_row_pos);
- NullState null_state = is_null ? NullState::IS_NULL :
NullState::NOT_NULL;
- return RowCursorCell(ref.data, null_state);
- }
-
~RowInBlock() {
for (auto agg_place : _agg_places) {
delete [] agg_place;
}
}
};
+
class RowInBlockComparator {
public:
- RowInBlockComparator(const Schema* schema):_schema(schema){};
+ RowInBlockComparator(const Schema* schema) : _schema(schema) {};
//call set_block before operator().
//在第一次insert block时创建的 _input_mutable_block,
所以无法在Comparator的构造函数中获得pblock
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
