xy720 commented on code in PR #9164: URL: https://github.com/apache/incubator-doris/pull/9164#discussion_r857919153
########## be/src/runtime/routine_load/data_consumer_pool.cpp: ########## @@ -67,12 +67,18 @@ Status DataConsumerPool::get_consumer_grp(StreamLoadContext* ctx, "PAUSE: Currently only support consumer group for Kafka data source"); } DCHECK(ctx->kafka_info); + DCHECK(ctx->kafka_info->begin_offset.size() > 0); Review Comment: In the create statement example below, you can see The user didn't specify the custom partitions. So that 1、Fe will get all kafka partitions from server in routine load's scheduler. The user set the default offset by datetime. So that 2、Fe will get kafka offset by time from server in routine load's scheduler. When 1 is success, meanwhile 2 is failed, the progress of this routine load may not contains any partitions and offsets. Nevertheless, since newCurrentKafkaPartition which is get by kafka server may be always equal to currentKafkaPartitions, the wrong progress will never be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org