github-actions[bot] commented on code in PR #42066:
URL: https://github.com/apache/doris/pull/42066#discussion_r1805782968
##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -1610,6 +1656,16 @@ void drop_tablet_callback(StorageEngine& engine, const
TAgentTaskRequest& req) {
remove_task_info(req.task_type, req.signature);
}
+void drop_tablet_callback(CloudStorageEngine& engine, const TAgentTaskRequest&
req) {
+ const auto& drop_tablet_req = req.drop_tablet_req;
+ // 1. erase lru from tablet mgr
+ // TODO(dx) clean tablet file cache
+ // get tablet's info(such as cachekey, tablet id, rsid)
+ engine.tablet_mgr().erase_tablet(drop_tablet_req.tablet_id);
+ // 2. gen clean file cache task
+ return;
Review Comment:
warning: redundant return statement at the end of a function with a void
return type [readability-redundant-control-flow]
be/src/agent/task_worker_pool.cpp:1664:
```diff
- // 2. gen clean file cache task
- return;
- }
+ }
```
##########
be/src/cloud/cloud_tablet_mgr.h:
##########
@@ -17,6 +17,9 @@
#pragma once
+#include <gen_cpp/MasterService_types.h>
Review Comment:
warning: 'gen_cpp/MasterService_types.h' file not found
[clang-diagnostic-error]
```cpp
#include <gen_cpp/MasterService_types.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
