github-actions[bot] commented on code in PR #41701:
URL: https://github.com/apache/doris/pull/41701#discussion_r1804693181
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -831,98 +885,250 @@ Status
VerticalSegmentWriter::_generate_flexible_read_plan(
Status VerticalSegmentWriter::_merge_rows_for_sequence_column(
Review Comment:
warning: function '_merge_rows_for_sequence_column' has cognitive complexity
of 76 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status VerticalSegmentWriter::_merge_rows_for_sequence_column(
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:906:** nesting
level increased to 1
```cpp
auto append_row = [&](int64_t rid, BitmapValue& skip_bitmap, bool
have_delete_sign) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:907:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (have_delete_sign) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:920:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:921:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if ((cur_rows == 1 && !have_rows_with_delete_sign) || cur_rows
== 2) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:921:** +1
```cpp
if ((cur_rows == 1 && !have_rows_with_delete_sign) || cur_rows
== 2) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:921:** +1
```cpp
if ((cur_rows == 1 && !have_rows_with_delete_sign) || cur_rows
== 2) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:944:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:955:** nesting
level increased to 1
```cpp
auto aggregate_rows = [&](std::string key, int64_t start, int64_t end)
-> Status {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:957:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (end - start == 1) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:972:** +1
```cpp
DCHECK(st.is<KEY_NOT_FOUND>() || st.ok());
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:975:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (st.ok()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:976:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (int64_t i {start}; i < end; i++) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:982:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (!row_has_sequence_col) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:987:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:990:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
if (Slice {seq_val}.compare(Slice
{previous_encoded_seq_value}) >= 0) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:998:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1003:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (row_has_sequence_col) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1008:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1010:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_generate_encoded_default_seq_value(
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1010:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(_generate_encoded_default_seq_value(
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1017:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
for (int64_t rid {pos + 1}; rid < end; rid++) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1021:** +1
```cpp
(!skip_bitmap.contains(delete_sign_col_unique_id) &&
delete_signs[rid] != 0);
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1022:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (!row_has_sequence_col) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1024:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1027:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (Slice {seq_val}.compare(Slice {cur_seq_val}) >= 0) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1030:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1041:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
for (size_t block_pos {0}; block_pos < data.num_rows; block_pos++) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1043:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (block_pos > 0 && previous_key == key) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1043:** +1
```cpp
if (block_pos > 0 && previous_key == key) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1045:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1046:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (same_key_rows > 0) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1047:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(aggregate_rows(std::move(previous_key),
block_pos - same_key_rows,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1047:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(aggregate_rows(std::move(previous_key),
block_pos - same_key_rows,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1054:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (same_key_rows > 0) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1055:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(aggregate_rows(std::move(previous_key),
data.num_rows - same_key_rows,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:1055:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(aggregate_rows(std::move(previous_key),
data.num_rows - same_key_rows,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
