cambyzju commented on code in PR #41915:
URL: https://github.com/apache/doris/pull/41915#discussion_r1804175843
##########
be/src/olap/rowset/segment_v2/inverted_index_compaction.cpp:
##########
@@ -57,12 +62,6 @@ Status compact_column(int64_t index_id,
std::vector<lucene::store::Directory*>&
// when index_writer is destroyed, if closeDir is set, dir will be close
// _CLDECDELETE(dir) will try to ref_cnt--, when it decreases to 1, dir
will be destroyed.
_CLDECDELETE(dir)
- for (auto* d : src_index_dirs) {
- if (d != nullptr) {
- d->close();
Review Comment:
destructor function of DorisCompoundReader will do it:
```
DorisCompoundReader::~DorisCompoundReader() {
if (!_closed) {
try {
close();
} catch (CLuceneError& err) {
LOG(ERROR) << "DorisCompoundReader finalize error:" <<
err.what();
}
}
_CLDELETE(entries)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
