morningman commented on code in PR #41607:
URL: https://github.com/apache/doris/pull/41607#discussion_r1804085056
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -663,6 +671,9 @@ public class SessionVariable implements Serializable,
Writable {
public static final String ADAPTIVE_PIPELINE_TASK_SERIAL_READ_ON_LIMIT =
"adaptive_pipeline_task_serial_read_on_limit";
+ @VariableMgr.VarAttr(name = VARIABLE_VERSION, flag = VariableMgr.INVISIBLE
| VariableMgr.READ_ONLY)
Review Comment:
should move it to GlobalVariable?
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1599,6 +1599,47 @@ private void transferToMaster() {
// Set initial root password if master FE first time launch.
auth.setInitialRootPassword(Config.initial_root_password);
} else {
+ int currentVariableVersion =
VariableMgr.newSessionVariable().variableVersion;
Review Comment:
How about create a new class and move these logic to there.
The Env.java is too big
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
