yiguolei commented on code in PR #41968:
URL: https://github.com/apache/doris/pull/41968#discussion_r1804074075
##########
be/src/vec/sink/vdata_stream_sender.h:
##########
@@ -193,47 +211,23 @@ class Channel {
return false;
}
- Status _wait_last_brpc() {
- SCOPED_TIMER(_parent->brpc_wait_timer());
- if (_send_remote_block_callback == nullptr) {
- return Status::OK();
- }
- _send_remote_block_callback->join();
- if (_send_remote_block_callback->cntl_->Failed()) {
- std::string err = fmt::format(
- "failed to send brpc batch, error={}, error_text={},
client: {}, "
- "latency = {}",
- berror(_send_remote_block_callback->cntl_->ErrorCode()),
- _send_remote_block_callback->cntl_->ErrorText(),
- BackendOptions::get_localhost(),
- _send_remote_block_callback->cntl_->latency_us());
- LOG(WARNING) << err;
- return Status::RpcError(err);
- }
- _receiver_status =
Status::create(_send_remote_block_callback->response_->status());
- return _receiver_status;
- }
-
- Status close_internal(Status exec_status);
+ Status _wait_last_brpc();
- Parent* _parent = nullptr;
+ pipeline::ExchangeSinkLocalState* _parent = nullptr;
- const RowDescriptor& _row_desc;
const TUniqueId _fragment_instance_id;
PlanNodeId _dest_node_id;
// the number of RowBatch.data bytes sent successfully
int64_t _num_data_bytes_sent {};
int64_t _packet_seq {};
- bool _need_close;
- bool _closed;
+ bool _need_close {};
Review Comment:
明确写上，是true还是false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
