HappenLee commented on code in PR #41681:
URL: https://github.com/apache/doris/pull/41681#discussion_r1802296304
##########
be/src/vec/functions/function_string.cpp:
##########
@@ -640,6 +788,38 @@ class FunctionTrim : public IFunction {
}
};
+template <typename impl>
Review Comment:
Impl and the `FunctionTrimIn` code is same as `FunctionTrim`. should reuse
not imple another
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
