Mryange opened a new pull request, #41917:
URL: https://github.com/apache/doris/pull/41917

   ## Proposed changes
   The shorten-64-to-32 check cannot detect conversions such as 64-bit to 
16-bit.
   
   ```C++
   #pragma clang diagnostic push
   #pragma clang diagnostic error "-Wconversion"
   #pragma clang diagnostic ignored "-Wsign-conversion"
   #pragma clang diagnostic ignored "-Wfloat-conversion"
       {
           int64_t x = 1000000;
           int y = x;//Implicit conversion loses integer precision: 'int64_t' 
(aka 'long long') to 'int'
       }
       {
           int64_t x = 1000000;
           int16_t y = x;//Implicit conversion loses integer precision: 
'int64_t' (aka 'long long') to 'int16_t' (aka 'short')
       }
       {
           int64_t x;
           uint64_t y = x;
       }
   #pragma clang diagnostic pop
   
   #pragma clang diagnostic push
   #pragma clang diagnostic error "-Wshorten-64-to-32"
       {
           int64_t x = 1000000;
           int y = x;//Implicit conversion loses integer precision: 'int64_t' 
(aka 'long long') to 'int'
       }
       {
           int64_t x = 1000000;
           int16_t y = x;
       }
       {
           int64_t x;
           uint64_t y = x;
       }
   #pragma clang diagnostic pop
   ```
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to