github-actions[bot] commented on code in PR #41760:
URL: https://github.com/apache/doris/pull/41760#discussion_r1797631089
##########
be/src/olap/rowset/beta_rowset_reader.h:
##########
@@ -47,11 +47,14 @@ class BetaRowsetReader : public RowsetReader {
~BetaRowsetReader() override { _rowset->release(); }
- Status init(RowsetReaderContext* read_context, const RowSetSplits&
rs_splits) override;
+ Status init(RowsetReaderContext* read_context, const RowSetSplits&
rs_splits,
+ long tz_offset) override;
Status get_segment_iterators(RowsetReaderContext* read_context,
std::vector<RowwiseIteratorUPtr>* out_iters,
bool use_cache = false) override;
+
+ long tz_offset() { return _tz_offset; }
Review Comment:
warning: method 'tz_offset' can be made const
[readability-make-member-function-const]
```suggestion
long tz_offset() const { return _tz_offset; }
```
##########
be/src/vec/data_types/data_type_time_v2.h:
##########
@@ -173,9 +186,10 @@
private:
UInt32 _scale;
+ bool _is_timestamp;
};
-DataTypePtr create_datetimev2(UInt64 scale);
+DataTypePtr create_datetimev2(UInt64 scale, bool is_timestamp = 0);
Review Comment:
warning: converting integer literal to bool, use bool literal instead
[modernize-use-bool-literals]
```suggestion
DataTypePtr create_datetimev2(UInt64 scale, bool is_timestamp = false);
```
##########
be/src/vec/data_types/data_type_time_v2.h:
##########
@@ -112,16 +112,27 @@ class DataTypeDateTimeV2 final : public
DataTypeNumberBase<UInt64> {
public:
static constexpr bool is_parametric = true;
- DataTypeDateTimeV2(UInt32 scale = 0) : _scale(scale) {
+ DataTypeDateTimeV2(UInt32 scale = 0, bool is_timestamp = 0)
Review Comment:
warning: converting integer literal to bool, use bool literal instead
[modernize-use-bool-literals]
```suggestion
DataTypeDateTimeV2(UInt32 scale = 0, bool is_timestamp = false)
```
##########
be/src/vec/columns/column_string.h:
##########
@@ -266,7 +266,8 @@ class ColumnStr final : public COWHelper<IColumn,
ColumnStr<T>> {
}
void insert_many_binary_data(char* data_array, uint32_t* len_array,
- uint32_t* start_offset_array, size_t num)
override {
+ uint32_t* start_offset_array, size_t num,
Review Comment:
warning: pointer parameter 'start_offset_array' can be pointer to const
[readability-non-const-parameter]
```suggestion
const uint32_t* start_offset_array, size_t
num,
```
##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -824,6 +824,41 @@
return val;
}
+ static uint64_t from_utc_datetime(long tz_offset, uint64_t datetime) {
+ union DateTimeV2UInt64Union {
+ DateV2Value<DateTimeV2ValueType> dt;
+ uint64_t ui64;
+ ~DateTimeV2UInt64Union() {}
+ };
+
+ DateTimeV2UInt64Union conv = {.ui64 = datetime};
+
+ DateV2Value<DateTimeV2ValueType> tmp = conv.dt;
+ tmp.date_add_interval<TimeUnit::SECOND>(TimeInterval
{TimeUnit::SECOND, tz_offset, false});
+ conv.dt = tmp;
+
+ return conv.ui64;
+ }
+
+ uint64_t to_utc_datetime(long tz_offset) const {
+ union DateTimeV2UInt64Union {
+ DateV2Value<DateTimeV2ValueType> dt;
+ uint64_t ui64;
+ ~DateTimeV2UInt64Union() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~DateTimeV2UInt64Union() = default;
```
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -270,7 +286,8 @@ class PredicateColumnType final : public COWHelper<IColumn,
PredicateColumnType<
}
void insert_many_binary_data(char* data_array, uint32_t* len_array,
- uint32_t* start_offset_array, size_t num)
override {
+ uint32_t* start_offset_array, size_t num,
Review Comment:
warning: pointer parameter 'start_offset_array' can be pointer to const
[readability-non-const-parameter]
```suggestion
const uint32_t* start_offset_array, size_t
num,
```
##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -824,6 +824,41 @@ class DateV2Value {
return val;
}
+ static uint64_t from_utc_datetime(long tz_offset, uint64_t datetime) {
+ union DateTimeV2UInt64Union {
+ DateV2Value<DateTimeV2ValueType> dt;
+ uint64_t ui64;
+ ~DateTimeV2UInt64Union() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~DateTimeV2UInt64Union() = default;
```
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -112,7 +113,8 @@ OlapBlockDataConvertor::create_agg_state_convertor(const
TabletColumn& column) {
}
OlapBlockDataConvertor::OlapColumnDataConvertorBaseUPtr
-OlapBlockDataConvertor::create_olap_column_data_convertor(const TabletColumn&
column) {
+OlapBlockDataConvertor::create_olap_column_data_convertor(const TabletColumn&
column,
Review Comment:
warning: function 'create_olap_column_data_convertor' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
OlapBlockDataConvertor::create_olap_column_data_convertor(const
TabletColumn& column,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/olap/olap_data_convertor.cpp:115:** 108 lines including
whitespace and comments (threshold 80)
```cpp
OlapBlockDataConvertor::create_olap_column_data_convertor(const
TabletColumn& column,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
