xzj7019 commented on code in PR #41731:
URL: https://github.com/apache/doris/pull/41731#discussion_r1797537051
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -60,30 +67,84 @@
public class PullUpPredicates extends PlanVisitor<ImmutableSet<Expression>,
Void> {
Map<Plan, ImmutableSet<Expression>> cache = new IdentityHashMap<>();
+ private final boolean getAllPredicates;
+
+ public PullUpPredicates(boolean all) {
+ getAllPredicates = all;
+ }
@Override
public ImmutableSet<Expression> visit(Plan plan, Void context) {
- if (plan.arity() == 1) {
Review Comment:
why not remain this and avoid override too many plan visitor whose pullup is
disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
