dataroaring commented on PR #9180: URL: https://github.com/apache/incubator-doris/pull/9180#issuecomment-1107790430
> > It is dangerous to only keep the latest image file, because an image file is > > validated when generating the next image file. Then we keep an non validated > > image file but remove validated ones. > > now the old validated ones will not be removed when new images is invalid, pr #9011 provide this solution, maybe we need to find the situation why image would be broken. actually, this patch fix a case in which image file is broken. I have a look at #9001, IMHO, we should keep at least 2 image file, because if we kept the one generated just now, it is hard to make sure the data is flushed to disk, especially, if a power off happened. I will send out the code I wrote yesterday for discussing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
