seawinde commented on code in PR #41691: URL: https://github.com/apache/doris/pull/41691#discussion_r1796380226
########## fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionCheckUtil.java: ########## @@ -0,0 +1,125 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.mtmv; + +import org.apache.doris.analysis.PartitionExprUtil; +import org.apache.doris.analysis.PartitionExprUtil.FunctionIntervalInfo; +import org.apache.doris.catalog.DynamicPartitionProperty; +import org.apache.doris.catalog.OlapTable; +import org.apache.doris.catalog.PartitionType; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.common.Pair; +import org.apache.doris.common.util.DynamicPartitionUtil; + +import com.google.common.annotations.VisibleForTesting; + +import java.util.Objects; + +public class MTMVPartitionCheckUtil { + /** + * Check if the partitioning method of the table meets the requirements for multi table partitioning updates + * + * @param tableIf base table of materialized view + * @return Inspection results and reasons + */ + public static Pair<Boolean, String> checkIfAllowMultiTablePartitionRefresh(MTMVRelatedTableIf tableIf) { + if (!(tableIf instanceof OlapTable)) { + return Pair.of(false, "only support OlapTable"); + } + OlapTable olapTable = (OlapTable) tableIf; + if (olapTable.getPartitionType() != PartitionType.RANGE) { + return Pair.of(false, "only support range partition"); + } + boolean isDynamicOrAuto = isDynamicPartition(olapTable) || isAutoPartition(olapTable); + if (!isDynamicOrAuto) { + return Pair.of(false, "only support dynamic/auto partition"); + } + return Pair.of(true, ""); + } + + /** + * Compare whether the partitioning rules of two tables are consistent + * + * @param originalTable partition table of materialized view + * @param relatedTable Partition refresh table for materialized views + * @return Inspection results and reasons + * @throws AnalysisException The preconditions are not met + */ + public static Pair<Boolean, String> compareOriginalTableAndRelatedTable(OlapTable originalTable, + OlapTable relatedTable) throws AnalysisException { + if (isDynamicPartition(originalTable)) { + return compareDynamicPartition(originalTable, relatedTable); + } else if (isAutoPartition(originalTable)) { + return compareAutoPartition(originalTable, relatedTable); + } else { + throw new AnalysisException("only support dynamic/auto partition"); + } + } + + @VisibleForTesting + public static Pair<Boolean, String> compareDynamicPartition(OlapTable originalTable, + OlapTable relatedTable) throws AnalysisException { Review Comment: `OlapTable relatedTable` is `List<OlapTable>relatedTable` may be better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
