zhangstar333 commented on PR #41626:
URL: https://github.com/apache/doris/pull/41626#issuecomment-2404585377

   > please check convertToLegacyAutoPartitionExprs method in 
PartitionTableInfo.java. I think it needs to be updated for nereids too
   ```
           ArrayList<Expr> exprs = 
convertToLegacyAutoPartitionExprs(partitionList);
           try {
               identifierPartitionColumns = 
PartitionDesc.getColNamesFromExpr(exprs,
                       
partitionType.equalsIgnoreCase(PartitionType.LIST.name()), isAutoPartition);
           } catch (Exception e) {
               throw new AnalysisException(e.getMessage(), e.getCause());
           }
   ```
   now the check in `PartitionDesc.getColNamesFromExpr` function,
   so after `convertToLegacyAutoPartitionExprs` function, 
   will be report error `PartitionDesc.getColNamesFromExpr`, no need check it 
in `convertToLegacyAutoPartitionExprs`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to