yiguolei commented on code in PR #41429:
URL: https://github.com/apache/doris/pull/41429#discussion_r1795002059
##########
be/src/olap/tablet_schema.h:
##########
@@ -286,16 +300,18 @@ class TabletIndex {
IndexType _index_type;
std::vector<int32_t> _col_unique_ids;
std::map<string, string> _properties;
+ int64_t _vl_field_mem_size {0}; // variable length field
};
-class TabletSchema {
+class TabletSchema : public MetadataAdder<TabletSchema> {
public:
enum ColumnType { NORMAL = 0, DROPPED = 1, VARIANT = 2 };
// TODO(yingchun): better to make constructor as private to avoid
// manually init members incorrectly, and define a new function like
// void create_from_pb(const TabletSchemaPB& schema, TabletSchema*
tablet_schema).
- TabletSchema();
- virtual ~TabletSchema();
+ TabletSchema() = default;
+ virtual ~TabletSchema() = default;
+ TabletSchema(const TabletSchema& other);
Review Comment:
为什么需要增加这个方法
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
