github-actions[bot] commented on code in PR #41646:
URL: https://github.com/apache/doris/pull/41646#discussion_r1794615699
##########
be/src/vec/columns/column_struct.h:
##########
@@ -89,6 +89,15 @@ class ColumnStruct final : public COWHelper<IColumn,
ColumnStruct> {
MutableColumnPtr clone_resized(size_t size) const override;
size_t size() const override { return columns.at(0)->size(); }
+ bool is_exclusive() const override {
Review Comment:
warning: function 'is_exclusive' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_exclusive() const override {
```
##########
be/src/vec/columns/column_map.h:
##########
@@ -96,6 +96,10 @@ class ColumnMap final : public COWHelper<IColumn, ColumnMap>
{
bool is_variable_length() const override { return true; }
bool can_be_inside_nullable() const override { return true; }
+ bool is_exclusive() const override {
Review Comment:
warning: function 'is_exclusive' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_exclusive() const override {
```
##########
be/src/vec/columns/column_array.h:
##########
@@ -129,6 +129,11 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
bool is_column_array() const override { return true; }
bool can_be_inside_nullable() const override { return true; }
bool is_variable_length() const override { return true; }
+
+ bool is_exclusive() const override {
Review Comment:
warning: function 'is_exclusive' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_exclusive() const override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
