github-actions[bot] commented on code in PR #39756:
URL: https://github.com/apache/doris/pull/39756#discussion_r1793145481
##########
be/src/olap/base_tablet.cpp:
##########
@@ -994,12 +1032,142 @@ Status
BaseTablet::generate_new_block_for_partial_update(
mutable_column->insert_default();
}
} else {
- mutable_column->insert_from(
-
*old_block.get_columns_with_type_and_name()[i].column.get(),
- read_index_old[idx]);
+
mutable_column->insert_from(*old_block.get_by_position(i).column,
+ read_index_old[idx]);
+ }
+ }
+ }
+ output_block->set_columns(std::move(full_mutable_columns));
+ VLOG_DEBUG << "full block when publish: " << output_block->dump_data();
+ return Status::OK();
+}
+
+Status BaseTablet::generate_new_block_for_flexible_partial_update(
Review Comment:
warning: function 'generate_new_block_for_flexible_partial_update' exceeds
recommended size/complexity thresholds [readability-function-size]
```cpp
Status BaseTablet::generate_new_block_for_flexible_partial_update(
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/base_tablet.cpp:1044:** 123 lines including whitespace and
comments (threshold 80)
```cpp
Status BaseTablet::generate_new_block_for_flexible_partial_update(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
