This is an automated email from the ASF dual-hosted git repository.

gavinchou pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 95479a995e4261fc6835ae192d69876cb35fa954
Author: Socrates <suxiaogang...@icloud.com>
AuthorDate: Fri Sep 27 16:22:44 2024 +0800

    [fix](hudi) fix fe memory leak  (#41256)
    
    ## Proposed changes
    related pr: https://github.com/apache/doris/pull/41225
    Should not set disable.cache to true, this will result in the
    accumulation of com.aliyun.oss.ClientConfiguration.
    <!--Describe your changes.-->
---
 .../doris/datasource/hive/HiveMetaStoreClientHelper.java       | 10 ----------
 1 file changed, 10 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreClientHelper.java
 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreClientHelper.java
index db6019eda97..97032467cec 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreClientHelper.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreClientHelper.java
@@ -67,7 +67,6 @@ import org.apache.hudi.common.table.TableSchemaResolver;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
-import java.net.URI;
 import java.security.PrivilegedExceptionAction;
 import java.time.LocalDateTime;
 import java.time.ZoneId;
@@ -829,15 +828,6 @@ public class HiveMetaStoreClientHelper {
     public static HoodieTableMetaClient getHudiClient(HMSExternalTable table) {
         String hudiBasePath = table.getRemoteTable().getSd().getLocation();
         Configuration conf = getConfiguration(table);
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("try setting 'fs.xxx.impl.disable.cache' to true for 
hudi's base path: {}", hudiBasePath);
-        }
-        URI hudiBasePathUri = URI.create(hudiBasePath);
-        String scheme = hudiBasePathUri.getScheme();
-        if (!Strings.isNullOrEmpty(scheme)) {
-            // Avoid using Cache in Hadoop FileSystem, which may cause FE OOM.
-            conf.set("fs." + scheme + ".impl.disable.cache", "true");
-        }
         return HadoopUGI.ugiDoAs(AuthenticationConfig.getKerberosConfig(conf),
                 () -> 
HoodieTableMetaClient.builder().setConf(conf).setBasePath(hudiBasePath).build());
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to