eldenmoon commented on code in PR #40573:
URL: https://github.com/apache/doris/pull/40573#discussion_r1778429742
##########
be/src/vec/common/schema_util.cpp:
##########
@@ -231,9 +235,16 @@ void get_column_by_type(const vectorized::DataTypePtr&
data_type, const std::str
column.set_length(data_type->get_size_of_value_in_memory());
return;
}
- // TODO handle more types like struct/date/datetime/decimal...
- LOG(FATAL) << "__builtin_unreachable";
- __builtin_unreachable();
+ if (WhichDataType(*data_type).is_decimal()) {
+ column.set_precision(data_type->get_precision());
+ column.set_frac(data_type->get_scale());
+ return;
+ }
+ if (WhichDataType(*data_type).is_date_time_v2()) {
+ column.set_precision(-1);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
