BiteTheDDDDt commented on code in PR #9147:
URL: https://github.com/apache/incubator-doris/pull/9147#discussion_r855103814
##########
be/src/exprs/table_function/table_function_factory.cpp:
##########
@@ -92,14 +85,32 @@ const std::unordered_map<std::pair<std::string, bool>,
std::function<TableFuncti
{{"explode_json_array_string", true},
VExplodeJsonArrayStringCreator},
{{"explode_bitmap", true},
TableFunctionCreator<vectorized::VExplodeBitmapTableFunction>()},
- {{"explode", true}, VExplodeCreator},
- {{"explode_outer", true}, VExplodeOuterCreator}}; // namespace
doris
+ {{"explode", true},
TableFunctionCreator<vectorized::VExplodeTableFunction> {}}};
+
+Status TableFunctionFactory::get_fn(std::string fn_name, bool is_vectorized,
ObjectPool* pool,
+ TableFunction** fn) {
+ bool is_outer = false;
+
+ auto match_suffix = [](const std::string& name, const std::string& suffix)
-> bool {
+ return name.substr(name.length() - suffix.length()) == suffix;
Review Comment:
I think maybe it's not necessary to do the check here?
http://www.cplusplus.com/reference/string/string/substr/
`Number of characters to include in the substring (if the string is shorter,
as many characters as possible are used).`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
