CalvinKirs commented on code in PR #41316:
URL: https://github.com/apache/doris/pull/41316#discussion_r1778095534


##########
fe/fe-common/pom.xml:
##########
@@ -132,6 +132,15 @@ under the License.
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-core</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.aliyun.oss</groupId>
+            <artifactId>aliyun-sdk-oss</artifactId>
+            <version>3.15.0</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.hadoop</groupId>
+            <artifactId>hadoop-aliyun</artifactId>
+        </dependency>

Review Comment:
   If the user doesn't use OSS and deletes this package when packaging (or 
deletes the dependency when building it himself), can other functions run 
normally at this time? Considering the security issues of various third-party 
dependencies later, I hope that these dependencies can be deleted at any time 
without modifying the code. Translated into authentic American English



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to