qidaye commented on code in PR #41371:
URL: https://github.com/apache/doris/pull/41371#discussion_r1777937731


##########
be/src/olap/rowset/segment_v2/inverted_index_compaction.cpp:
##########
@@ -40,8 +40,9 @@ Status compact_column(int64_t index_id, 
std::vector<lucene::store::Directory*>&
                     "debug point: index compaction error");
         }
     })
-    lucene::store::Directory* dir =
-            
DorisFSDirectoryFactory::getDirectory(io::global_local_filesystem(), 
tmp_path.data());
+    bool can_use_ram_dir = true;

Review Comment:
   This is the input arg to the getDirectory method.
   If only `can_use_ram_dir` and `config::inverted_index_ram_dir_enable` both 
are true, we can actually use the RAM direcotry.



##########
be/src/olap/rowset/segment_v2/inverted_index_compaction.cpp:
##########
@@ -40,8 +40,9 @@ Status compact_column(int64_t index_id, 
std::vector<lucene::store::Directory*>&
                     "debug point: index compaction error");
         }
     })
-    lucene::store::Directory* dir =
-            
DorisFSDirectoryFactory::getDirectory(io::global_local_filesystem(), 
tmp_path.data());
+    bool can_use_ram_dir = true;

Review Comment:
   This is the input arg to the getDirectory method.
   If only `can_use_ram_dir` and `config::inverted_index_ram_dir_enable` both 
are true, we can actually use the RAM directory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to