This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push: new cf1217fd07b [chore](cancel log) Remove some cancel log on FE (#41312) cf1217fd07b is described below commit cf1217fd07bdd5643efa1e2002290f1c3d4a36c8 Author: zhiqiang <seuhezhiqi...@163.com> AuthorDate: Fri Sep 27 11:09:20 2024 +0800 [chore](cancel log) Remove some cancel log on FE (#41312) Too many error log on FE when query is cancelled. --- .../main/java/org/apache/doris/qe/Coordinator.java | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java index 4ac83361e25..19f06249aa3 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java +++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java @@ -1298,16 +1298,19 @@ public class Coordinator implements CoordInterface { lock(); try { if (!queryStatus.ok()) { - // Print an error stack here to know why send cancel again. - LOG.warn("Query {} already in abnormal status {}, but received cancel again," - + "so that send cancel to BE again", - DebugUtil.printId(queryId), queryStatus.toString(), - new Exception("cancel failed")); + if (LOG.isDebugEnabled()) { + // Print an error stack here to know why send cancel again. + LOG.debug("Query {} already in abnormal status {}, but received cancel again," + + "so that send cancel to BE again", + DebugUtil.printId(queryId), queryStatus.toString(), + new Exception("cancel failed")); + } } else { queryStatus.updateStatus(cancelReason.getErrorCode(), cancelReason.getErrorMsg()); + LOG.warn("Cancel execution of query {}, this is a outside invoke, cancelReason {}", + DebugUtil.printId(queryId), cancelReason.toString()); } - LOG.warn("Cancel execution of query {}, this is a outside invoke, cancelReason {}", - DebugUtil.printId(queryId), cancelReason.toString()); + cancelInternal(cancelReason); } finally { unlock(); @@ -3026,10 +3029,9 @@ public class Coordinator implements CoordInterface { } if (this.hasCancelled || this.cancelInProcess) { - LOG.info("Frangment has already been cancelled. Query {} backend: {}", - DebugUtil.printId(queryId), idToBackend.get(beId)); return; } + try { try { ListenableFuture<InternalService.PCancelPlanFragmentResult> cancelResult = @@ -3047,8 +3049,6 @@ public class Coordinator implements CoordInterface { DebugUtil.printId(queryId), idToBackend.get(beId), status.toString()); } } - LOG.warn("Failed to cancel query {} backend: {} reason: {}", - DebugUtil.printId(queryId), idToBackend.get(beId), "without status"); } public void onFailure(Throwable t) { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org