xiaokang commented on code in PR #39932: URL: https://github.com/apache/doris/pull/39932#discussion_r1777864304
########## be/CMakeLists.txt: ########## @@ -69,6 +69,9 @@ endif() # enable glog custom prefix add_definitions(-DGLOG_CUSTOM_PREFIX_SUPPORT) +# enable simdjson check eof +add_definitions(-DSIMDJSON_CHECK_EOF) Review Comment: The official comment in simdjson does not suggest turn it on. `option(SIMDJSON_CHECK_EOF "Check for the end of the input buffer. The setting is unnecessary since we require padding of the inputs. You should expect tests to fail with this option turned on." OFF)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
