TangSiyang2001 commented on code in PR #41357:
URL: https://github.com/apache/doris/pull/41357#discussion_r1777193609
##########
be/src/cloud/cloud_rowset_writer.cpp:
##########
@@ -34,7 +35,14 @@ Status CloudRowsetWriter::init(const RowsetWriterContext&
rowset_writer_context)
if (_context.is_local_rowset()) {
// In cloud mode, this branch implies it is an intermediate rowset for
external merge sort,
// we use `global_local_filesystem` to write data to
`tmp_file_dir`(see `local_segment_path`).
- _context.tablet_path =
io::FileCacheFactory::instance()->get_cache_path();
+ if (auto maybe_cache_path =
io::FileCacheFactory::instance()->get_cache_path();
Review Comment:
We enable file cache by false after duscussion. As for the availability of
cache path, currently every cache has a working disk path. If mem cache is
introduced, we should modify the implementation of FileCacheFactory then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
