zhannngchen commented on code in PR #41172:
URL: https://github.com/apache/doris/pull/41172#discussion_r1773441155
##########
be/src/vec/sink/vtablet_block_convertor.cpp:
##########
@@ -568,10 +569,15 @@ Status
OlapTableBlockConvertor::_partial_update_fill_auto_inc_cols(vectorized::B
for (size_t i = 0; i < rows; i++) {
dst_values.emplace_back(_auto_inc_id_allocator.next_id());
}
+ // in VRowDistribution we reuse _batching_block, so the input block may
already include PARTIAL_UPDATE_AUTO_INC_COL,
Review Comment:
When you got here, which means the `block` object is from `_batching_block`,
it already have __PARTIAL_UPDATE_AUTO_INC_COL__, so we don't need to call the
method `_partial_update_fill_auto_inc_cols()`
we'd better to change the logic at L80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
