morrySnow commented on code in PR #41118:
URL: https://github.com/apache/doris/pull/41118#discussion_r1773014701
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -1555,7 +1555,7 @@ functionCallExpression
: functionIdentifier
LEFT_PAREN (
(DISTINCT|ALL)?
- arguments+=expression (COMMA arguments+=expression)*
+ arguments+=argumentExpression (COMMA
arguments+=argumentExpression)*
Review Comment:
1. namedExpression contains expression, so use namedExpression directly is ok
2. i think any other function should throw exception explicitly, such as
abs(a as b). so we should specific `struct` function and should not change any
other function 's syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
