This is an automated email from the ASF dual-hosted git repository.

w41ter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new e8812855dea [fix](migrate) Fix iterator returning too early (#41168)
e8812855dea is described below

commit e8812855deaa200d7566048df2dbfd4b20fc4591
Author: walter <w41te...@gmail.com>
AuthorDate: Tue Sep 24 10:38:17 2024 +0800

    [fix](migrate) Fix iterator returning too early (#41168)
    
    introduced in #41083.
    
    Because the iterator returns too early, only one piece of data is
    returned each time a binlog is obtained for a certain version range.
    When the system triggers compaction and generates a rowset that spans
    versions, the binlog files copied by the migrate task may be missed.
---
 be/src/olap/rowset/rowset_meta_manager.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/olap/rowset/rowset_meta_manager.cpp 
b/be/src/olap/rowset/rowset_meta_manager.cpp
index 9ba6f9540db..454eb1ac643 100644
--- a/be/src/olap/rowset/rowset_meta_manager.cpp
+++ b/be/src/olap/rowset/rowset_meta_manager.cpp
@@ -406,7 +406,7 @@ Status RowsetMetaManager::get_rowset_binlog_metas(OlapMeta* 
meta, TabletUid tabl
         binlog_meta_pb->set_data_key(binlog_data_key);
         binlog_meta_pb->set_data(binlog_data);
 
-        return false;
+        return true;
     };
 
     Status iterStatus =


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to