This is an automated email from the ASF dual-hosted git repository.

w41ter pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new 059f822a3a6 [fix](restore) Remove the sqlMode from the view signature 
#40615 (#41110)
059f822a3a6 is described below

commit 059f822a3a657082345e11d8d1ca9203a47f1c44
Author: walter <w41te...@gmail.com>
AuthorDate: Mon Sep 23 14:07:52 2024 +0800

    [fix](restore) Remove the sqlMode from the view signature #40615 (#41110)
    
    cherry pick from #40615
---
 fe/fe-core/src/main/java/org/apache/doris/catalog/View.java | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java 
b/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
index 5f8e1ba8138..d9e4ac84d92 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
@@ -218,7 +218,14 @@ public class View extends Table {
         sb.append(type);
         sb.append(Util.getSchemaSignatureString(fullSchema));
         sb.append(inlineViewDef);
-        sb.append(sqlMode);
+
+        // ATTN: sqlMode is missing when persist view, so we should not append 
it here.
+        //
+        // To keep compatible with the old version, without sqlMode, if the 
signature of views
+        // are the same, we think the should has the same sqlMode. (since the 
sqlMode doesn't
+        // effect the parsing of inlineViewDef, otherwise the parsing will 
fail),
+        //
+        // sb.append(sqlMode);
         String md5 = DigestUtils.md5Hex(sb.toString());
         if (LOG.isDebugEnabled()) {
             LOG.debug("get signature of view {}: {}. signature string: {}", 
name, md5, sb.toString());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to