gavinchou commented on code in PR #41087: URL: https://github.com/apache/doris/pull/41087#discussion_r1769710216
########## fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java: ########## @@ -331,7 +331,7 @@ private List<Pair<TGetTopNHotPartitionsResponse, Backend>> fetchOneClusterHotSpo return responseList; } - private Long getFileCacheUsedBytes(String clusterName) throws RuntimeException { + private Long getFileCacheTotalBytes(String clusterName) throws RuntimeException { Review Comment: ```suggestion private Long getFileCacheCapacity(String clusterName) throws RuntimeException { ``` ########## fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java: ########## @@ -436,7 +386,7 @@ private Map<Long, List<List<Long>>> splitBatch(Map<Long, List<Tablet>> beToWarmU } private Map<Long, List<Tablet>> warmUpNewClusterByCluster(String dstClusterName, String srcClusterName) { - Long dstTotalFileCache = getFileCacheUsedBytes(dstClusterName); + Long dstTotalFileCache = getFileCacheTotalBytes(dstClusterName); Review Comment: ```suggestion Long dstTotalFileCache = getFileCacheCapacity(dstClusterName); ``` ########## fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java: ########## @@ -571,7 +521,7 @@ private Map<Long, List<Tablet>> warmUpNewClusterByTable(long jobId, String dstCl List<Triple<String, String, String>> tables, boolean isForce) throws RuntimeException { Map<Long, List<Tablet>> beToWarmUpTablets = new HashMap<>(); - Long totalFileCache = getFileCacheUsedBytes(dstClusterName); + Long totalFileCache = getFileCacheTotalBytes(dstClusterName); Review Comment: ```suggestion Long totalFileCache = getFileCacheCapacity(dstClusterName); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org