yiguolei commented on code in PR #41062:
URL: https://github.com/apache/doris/pull/41062#discussion_r1769528464
##########
be/src/vec/columns/column.h:
##########
@@ -185,12 +185,21 @@ class IColumn : public COW<IColumn> {
/// Removes all elements outside of specified range.
/// Is used in LIMIT operation, for example.
- virtual Ptr cut(size_t start, size_t length) const {
+ virtual Ptr cut(size_t start, size_t length) const final {
Review Comment:
add beut for these 2 methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
