dataroaring commented on code in PR #40204:
URL: https://github.com/apache/doris/pull/40204#discussion_r1766470828
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -1166,6 +1178,49 @@ void DeleteBitmap::merge(const DeleteBitmap& other) {
}
}
+void DeleteBitmap::add_to_remove_queue(
+ const std::string& version_str,
+ const std::vector<std::tuple<int64_t, DeleteBitmap::BitmapKey,
DeleteBitmap::BitmapKey>>&
+ vector) {
+ std::shared_lock l(stale_delete_bitmap_lock);
+ _stale_delete_bitmap.emplace(version_str, vector);
+}
+
+void DeleteBitmap::remove_stale_delete_bitmap_from_queue(const
std::vector<std::string>& vector) {
+ std::shared_lock l(stale_delete_bitmap_lock);
+ //<rowset_id, start_version, end_version>
+ std::vector<std::tuple<std::string, uint64_t, uint64_t>> to_delete;
+ auto tablet_id = -1;
+ for (auto& version_str : vector) {
+ auto it = _stale_delete_bitmap.find(version_str);
+ if (it != _stale_delete_bitmap.end()) {
+ auto delete_bitmap_vector = it->second;
+ for (auto& delete_bitmap_tuple : it->second) {
+ if (tablet_id < 0) {
+ tablet_id = std::get<0>(delete_bitmap_tuple);
+ }
+ auto start_bmk = std::get<1>(delete_bitmap_tuple);
+ auto end_bmk = std::get<2>(delete_bitmap_tuple);
+ remove(start_bmk, end_bmk);
+
to_delete.emplace_back(std::make_tuple(std::get<0>(start_bmk).to_string(), 0,
+ std::get<2>(end_bmk)));
+ }
+ _stale_delete_bitmap.erase(version_str);
+ }
+ }
+ CloudStorageEngine& engine =
ExecEnv::GetInstance()->storage_engine().to_cloud();
Review Comment:
What happens when tablet_id is -1 and to_delete is empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
