github-actions[bot] commented on code in PR #40966: URL: https://github.com/apache/doris/pull/40966#discussion_r1766119849
########## be/src/exec/tablet_info.h: ########## @@ -90,6 +90,8 @@ class OlapTableSchemaParam { } void set_timestamp_ms(int64_t timestamp_ms) { _timestamp_ms = timestamp_ms; } int64_t timestamp_ms() const { return _timestamp_ms; } + void set_nano_seconds(int32_t nano_seconds) { _nano_seconds = nano_seconds; } + int32_t nano_seconds() const { return _nano_seconds; } Review Comment: warning: function 'nano_seconds' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] int32_t nano_seconds() const { return _nano_seconds; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org