LiBinfeng-01 commented on code in PR #40744:
URL: https://github.com/apache/doris/pull/40744#discussion_r1764526800
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DecimalV3Literal.java:
##########
@@ -84,6 +84,12 @@ public DecimalV3Literal roundFloor(int newScale) {
value.setScale(newScale, RoundingMode.FLOOR));
}
+ public DecimalV3Literal round(int newScale) {
+ return new DecimalV3Literal(DecimalV3Type
+ .createDecimalV3Type(((DecimalV3Type) dataType).getPrecision(),
newScale),
Review Comment:
when new scale is larger than original one, it would throw an
Invocationexception when calling create Decimal Type in java with message:
precision should not smaller than scale and ExpressionEvaluator would catch
this exception and go back to original expression. But actually when new scalar
bigger than old one, we can return original one when folding constant. Same as
be calculation logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
