morrySnow commented on code in PR #40767:
URL: https://github.com/apache/doris/pull/40767#discussion_r1764362633
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisLexer.g4:
##########
@@ -553,6 +554,7 @@ VARIABLE: 'VARIABLE';
VARIABLES: 'VARIABLES';
VARIANT: 'VARIANT';
VAULT: 'VAULT';
+VAULTS: 'VAULTS';
Review Comment:
VAULTS should be non-reserved keyword
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -183,8 +183,8 @@ unsupportedOtherStatement
| UNINSTALL PLUGIN name=identifierOrText
#uninstallPlugin
| LOCK TABLES (lockTable (COMMA lockTable)*)?
#lockTables
| UNLOCK TABLES
#unlockTables
- | WARM UP CLUSTER destination=identifier WITH
- (CLUSTER source=identifier | (warmUpItem (COMMA warmUpItem)*)) FORCE?
#warmUpCluster
+ | WARM UP (CLUSTER | COMPUTE GROUP) destination=identifier WITH
+ ((CLUSTER | COMPUTE GROUP) source=identifier | (warmUpItem (COMMA
warmUpItem)*)) FORCE? #warmUpCluster
Review Comment:
保持语句别名对齐（就是后面 # 部分）
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -8518,6 +8555,8 @@ keyword ::=
{: RESULT = id; :}
| KW_VAULT:id
{: RESULT = id; :}
+ | KW_VAULTS:id
Review Comment:
KW_GROUP should be non-reserved keyword
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
