zclllyybb commented on code in PR #40567:
URL: https://github.com/apache/doris/pull/40567#discussion_r1764324563
##########
be/src/vec/functions/function_string.h:
##########
@@ -2601,43 +2591,62 @@ class FunctionUrlDecode : public IFunction {
static FunctionPtr create() { return
std::make_shared<FunctionUrlDecode>(); }
String get_name() const override { return name; }
size_t get_number_of_arguments() const override { return 1; }
- bool is_variadic() const override { return false; }
-
DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
return std::make_shared<DataTypeString>();
}
- Status execute_impl(FunctionContext* context, Block& block,
-
- const ColumnNumbers& arguments, size_t result,
- size_t input_rows_count) const override {
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
auto res = ColumnString::create();
- auto& res_offsets = res->get_offsets();
- auto& res_chars = res->get_chars();
- res_offsets.resize(input_rows_count);
+ res->get_offsets().reserve(input_rows_count);
- ColumnPtr argument_column =
-
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
- const auto* url_col =
check_and_get_column<ColumnString>(argument_column.get());
+ const auto* url_col =
+ assert_cast<const
ColumnString*>(block.get_by_position(arguments[0]).column.get());
- if (!url_col) {
- return Status::InternalError("Not supported input argument type");
+ std::string decoded_url;
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ auto url = url_col->get_data_at(i);
+ if (!url_decode(url.to_string(), &decoded_url)) {
+ return Status::InternalError("Decode url failed");
+ }
+ res->insert_data(decoded_url.data(), decoded_url.size());
+ decoded_url.clear();
}
- std::string decoded_url;
+ block.get_by_position(result).column = std::move(res);
+ return Status::OK();
+ }
+};
- for (size_t i = 0; i < input_rows_count; ++i) {
- auto source = url_col->get_data_at(i);
- StringRef url_val(const_cast<char*>(source.data), source.size);
+class FunctionUrlEncode : public IFunction {
+public:
+ static constexpr auto name = "url_encode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlEncode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
- url_decode(url_val.to_string(), &decoded_url);
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto res = ColumnString::create();
+ res->get_offsets().reserve(input_rows_count);
- StringOP::push_value_string(decoded_url, i, res_chars,
res_offsets);
- decoded_url.clear();
+ const auto* url_col =
+ assert_cast<const
ColumnString*>(block.get_by_position(arguments[0]).column.get());
+
+ std::string encoded_url;
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ auto url = url_col->get_data_at(i);
+ if (!url_encode(url.to_string_view(), &encoded_url)) {
+ return Status::InternalError("Encode url failed");
Review Comment:
when will this happen? if for invalid inputs, it should be `InvalidArgument`
##########
regression-test/data/query_p0/sql_functions/string_functions/test_translate.out:
##########
@@ -0,0 +1,466 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !empty_nullable --
+
+-- !empty_not_nullable --
+
+-- !empty_partial_nullable --
+
+-- !nullable --
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+\N
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+!!!
+!@!@!$!^
+!@#!@#
+!@#@#$
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+!@#@#$#^$%%$^
+111
+1211131
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123123
+123233333
+\\\\\\
+\\a\\\\a\\
+\\a\\a\\c\\dccd
+\\a\\b\\c
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+\\a\\b\\c\\d
+中中
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中文
+中������
Review Comment:
We must consider UTF-8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
