HappenLee commented on code in PR #40821:
URL: https://github.com/apache/doris/pull/40821#discussion_r1759657133
##########
be/src/vec/functions/function_datetime_string_to_string.h:
##########
@@ -78,42 +123,65 @@ class FunctionDateTimeStringToString : public IFunction {
const ColumnPtr source_col =
block.get_by_position(arguments[0]).column;
const auto* nullable_column =
check_and_get_column<ColumnNullable>(source_col.get());
- const auto* sources = check_and_get_column<ColumnVector<typename
Transform::FromType>>(
+ const auto* sources = assert_cast<const ColumnVector<typename
Transform::FromType>*>(
nullable_column ?
nullable_column->get_nested_column_ptr().get()
: source_col.get());
- if (sources) {
- auto col_res = ColumnString::create();
- ColumnUInt8::MutablePtr col_null_map_to;
- col_null_map_to = ColumnUInt8::create();
- auto& vec_null_map_to = col_null_map_to->get_data();
-
- if (arguments.size() == 2) {
- const IColumn& source_col1 =
*block.get_by_position(arguments[1]).column;
- StringRef formatter =
- source_col1.get_data_at(0); // for both ColumnString
or ColumnConst.
- TransformerToStringTwoArgument<Transform>::vector_constant(
- context, sources->get_data(), formatter,
col_res->get_chars(),
- col_res->get_offsets(), vec_null_map_to);
- } else { //default argument
- TransformerToStringTwoArgument<Transform>::vector_constant(
- context, sources->get_data(), StringRef("%Y-%m-%d
%H:%i:%s"),
- col_res->get_chars(), col_res->get_offsets(),
vec_null_map_to);
- }
+ auto col_res = ColumnString::create();
+ ColumnUInt8::MutablePtr col_null_map_to;
+ col_null_map_to = ColumnUInt8::create();
+ auto& vec_null_map_to = col_null_map_to->get_data();
- if (nullable_column) {
- const auto& origin_null_map =
nullable_column->get_null_map_column().get_data();
- for (int i = 0; i < origin_null_map.size(); ++i) {
- vec_null_map_to[i] |= origin_null_map[i];
- }
+ RETURN_IF_ERROR(vector_constant(context, sources->get_data(),
col_res->get_chars(),
+ col_res->get_offsets(),
vec_null_map_to));
+
+ if (nullable_column) {
+ const auto& origin_null_map =
nullable_column->get_null_map_column().get_data();
+ for (int i = 0; i < origin_null_map.size(); ++i) {
+ vec_null_map_to[i] |= origin_null_map[i];
}
- block.get_by_position(result).column =
- ColumnNullable::create(std::move(col_res),
std::move(col_null_map_to));
- } else {
- return Status::InternalError("Illegal column {} of first argument
of function {}",
-
block.get_by_position(arguments[0]).column->get_name(),
- name);
}
+
+ block.get_by_position(result).column =
+ ColumnNullable::create(std::move(col_res),
std::move(col_null_map_to));
+
+ return Status::OK();
+ }
+
+ Status vector_constant(FunctionContext* context,
+ const PaddedPODArray<typename Transform::FromType>&
ts,
+ ColumnString::Chars& res_data,
ColumnString::Offsets& res_offsets,
+ PaddedPODArray<UInt8>& null_map) const {
+ auto* format_state = reinterpret_cast<FormatState*>(
+ context->get_function_state(FunctionContext::FRAGMENT_LOCAL));
+ if (!format_state) {
+ return Status::RuntimeError("funciton context for function '{}'
must have FormatState;",
+ get_name());
+ }
+
+ StringRef format(format_state->format_str);
+
+ auto len = ts.size();
+ res_offsets.resize(len);
+ res_data.reserve(len * format.size + len);
+ null_map.resize_fill(len, false);
+
+ if (!format_state->is_valid) {
Review Comment:
is_valid should set null, is danger behavioer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
