liaoxin01 commented on code in PR #40694:
URL: https://github.com/apache/doris/pull/40694#discussion_r1759124706
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -2888,9 +2888,10 @@ public void unsetFields() {
// Has to use synchronized to ensure there are not concurrent update
threads. Or the done
// state maybe update wrong and will lose data. see
https://github.com/apache/doris/pull/29802/files.
public synchronized boolean
updatePipelineStatus(TReportExecStatusParams params) {
- // The fragment or instance is not finished, not need update
+ // The fragment or instance is not finished, still need handle the
report to update the load progress.
+ // Otherwise the load progress (ScannedRows/LoadBytes) won't be
updated before any instance is done.
if (!params.done) {
- return false;
+ return true;
Review Comment:
This may bring some problems here, refer to the comments above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
