zhannngchen commented on code in PR #40204: URL: https://github.com/apache/doris/pull/40204#discussion_r1756801799
########## be/src/olap/tablet_meta.cpp: ########## @@ -1166,6 +1168,36 @@ void DeleteBitmap::merge(const DeleteBitmap& other) { } } +void DeleteBitmap::add_to_remove_queue( + const std::tuple<int64_t, DeleteBitmap::BitmapKey, DeleteBitmap::BitmapKey>& tuple, + int64_t time_stamp) { + std::shared_lock l(stale_delete_bitmap_lock); + _stale_delete_bitmap.emplace(tuple, time_stamp); +} + +void DeleteBitmap::remove_stale_delete_bitmap_from_queue() { + std::shared_lock l(stale_delete_bitmap_lock); + auto now = UnixMillis(); + auto it = _stale_delete_bitmap.begin(); + while (it != _stale_delete_bitmap.end()) { + if (now - it->second > config::tablet_rowset_stale_sweep_time_sec * 1000) { Review Comment: the config `tablet_rowset_stale_sweep_time_sec` is not for cloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org