zhannngchen commented on code in PR #40062:
URL: https://github.com/apache/doris/pull/40062#discussion_r1753561499
##########
be/src/olap/partial_update_info.cpp:
##########
@@ -126,6 +126,27 @@ std::string PartialUpdateInfo::summary() const {
update_cids.size(), missing_cids.size(), is_strict_mode,
max_version_in_flush_phase);
}
+Status PartialUpdateInfo::handle_non_strict_mode_not_found_error(
+ const TabletSchema& tablet_schema) {
+ if (!can_insert_new_rows_in_partial_update) {
Review Comment:
need to rebase to latest master to resolve the conflicts of #40322
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -683,29 +680,21 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
converted_result.second->get_data(),
num_rows));
}
- _num_rows_updated += num_rows_updated;
- _num_rows_deleted += num_rows_deleted;
- _num_rows_new_added += num_rows_new_added;
- _num_rows_filtered += num_rows_filtered;
+ _num_rows_updated += stats.num_rows_updated;
+ _num_rows_deleted += stats.num_rows_deleted;
+ _num_rows_new_added += stats.num_rows_new_added;
+ _num_rows_filtered += stats.num_rows_filtered;
if (_tablet_schema->has_sequence_col() && !have_input_seq_column) {
DCHECK_NE(seq_column, nullptr);
- DCHECK_EQ(_num_rows_written, row_pos)
Review Comment:
Why removed these DCHECKs?
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -528,7 +594,6 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
std::vector<RowsetSharedPtr> specified_rowsets;
{
Review Comment:
This whole block could be removed after #34112?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
