morrySnow commented on code in PR #40657: URL: https://github.com/apache/doris/pull/40657#discussion_r1753125514
########## regression-test/suites/insert_overwrite_p0/insert_overwrite_auto_detect.groovy: ########## @@ -150,10 +150,18 @@ suite("test_iot_auto_detect") { qt_sql " select * from dt order by k0; " try { sql """ insert overwrite table dt partition(*) values ("2023-02-02"), ("3000-12-12"); """ + fail() } catch (Exception e) { log.info(e.getMessage()) assertTrue(e.getMessage().contains('Insert has filtered data in strict mode') || e.getMessage().contains('Cannot found origin partitions in auto detect overwriting')) - } Review Comment: nit: could use test ```groovy test { sql """xxx""" check { result, exception, startTime, endTime -> ... } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org