Lchangliang commented on PR #8923: URL: https://github.com/apache/incubator-doris/pull/8923#issuecomment-1097631872
> `compression type` you mean used to compress page? page compress use LZ4F not LZ4， and compress type is defined in `CompressionTypePB` in `gensrc/proto/segment_v2.proto` no need to create new define in thrift, or thrift should keep consistent with proto, the actual compress algorithm is hard code in `be/src/olap/rowset/segment_v2/segment_writer.cpp` so I think we need more discuss for this pr I'm sorry. I misunderstood the code. As you say, the issue want to specify different algorithms to compress page. Maybe i can create thrift that keeps consistent with proto and persist on tabletSchema. In segment_writer.cpp, "meta->set_compression(LZ4F);" change to "meta->set_compression(_tablet_schema->compression_type());". BTW, I want to know that what the enum 'CompressKind' use to do ? Thank you for your correction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
