yujun777 commented on code in PR #40264:
URL: https://github.com/apache/doris/pull/40264#discussion_r1751172419
##########
docker/runtime/doris-compose/database.py:
##########
@@ -140,23 +161,53 @@ def decommission_be(self, be_endpoint):
time.sleep(5)
+ def create_default_storage_vault(self, cloud_store_config):
+ try:
+ # Create storage vault
+ create_vault_sql = f"""
+ CREATE STORAGE VAULT IF NOT EXISTS default_vault
+ PROPERTIES (
+ "type" = "S3",
+ "s3.access_key" = "{cloud_store_config['DORIS_CLOUD_AK']}",
+ "s3.secret_key" = "{cloud_store_config['DORIS_CLOUD_SK']}",
+ "s3.endpoint" = "{cloud_store_config['DORIS_CLOUD_ENDPOINT']}",
+ "s3.bucket" = "{cloud_store_config['DORIS_CLOUD_BUCKET']}",
+ "s3.region" = "{cloud_store_config['DORIS_CLOUD_REGION']}",
+ "s3.root.path" = "{str(uuid.uuid4())}",
+ "provider" = "{cloud_store_config['DORIS_CLOUD_PROVIDER']}"
+ );
+ """
+ self._exec_query(create_vault_sql)
+ LOG.info("Created storage vault 'default_vault'")
+
+ # Set as default storage vault
+ set_default_vault_sql = "SET default_vault as DEFAULT STORAGE
VAULT;"
+ self._exec_query(set_default_vault_sql)
+ LOG.info("Set 'default_vault' as the default storage vault")
+
+ except Exception as e:
+ LOG.error(f"Failed to create default storage vault: {str(e)}")
+ raise
+
def _load_fe_states(self, query_ports):
fe_states = {}
alive_master_fe_port = None
for record in self._exec_query('''
- select Host, IsMaster, Alive, LastHeartbeat, ErrMsg
- from frontends()'''):
- ip, is_master, alive, last_heartbeat, err_msg = record
+ show frontends '''):
Review Comment:
don't use "show frontends", make doris-compose is compatiable all branches
as posssible as we can.
Sometimes different branch, field in 'show frontends' may has different
diff field number.
use select xx, yy from frontends() can avoid this problem;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
