yiguolei commented on code in PR #40553:
URL: https://github.com/apache/doris/pull/40553#discussion_r1749938560
##########
be/src/exec/schema_scanner/schema_scanner_helper.cpp:
##########
@@ -50,8 +50,8 @@ void SchemaScannerHelper::insert_datetime_value(int
col_index, const std::vector
nullable_column->get_null_map_data().emplace_back(0);
}
-void SchemaScannerHelper::insert_int_value(int col_index, int64_t int_val,
- vectorized::Block* block) {
+void SchemaScannerHelper::insert_int64_value(int col_index, int64_t int_val,
+ vectorized::Block* block) {
vectorized::MutableColumnPtr mutable_col_ptr;
mutable_col_ptr =
std::move(*block->get_by_position(col_index).column).assume_mutable();
auto* nullable_column =
reinterpret_cast<vectorized::ColumnNullable*>(mutable_col_ptr.get());
Review Comment:
better to use assert cast instead of reinterpret_cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
