yiguolei commented on code in PR #40495: URL: https://github.com/apache/doris/pull/40495#discussion_r1749466893
########## be/src/vec/exec/scan/scanner_context.cpp: ########## @@ -214,7 +214,12 @@ void ScannerContext::append_block_to_queue(std::shared_ptr<ScanTask> scan_task) } } } - std::lock_guard<std::mutex> l(_transfer_lock); + std::unique_lock<std::mutex> l(_transfer_lock); + append_block_to_queue_locked(scan_task, l); Review Comment: 如果我们不处理submit 之后的重试,那么这个方法的拆分就意义不大了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org