github-actions[bot] commented on code in PR #40502:
URL: https://github.com/apache/doris/pull/40502#discussion_r1747864284
##########
be/src/vec/functions/function.h:
##########
@@ -447,9 +447,10 @@ class IFunction : public
std::enable_shared_from_this<IFunction>,
bool is_stateful() const override { return false; }
- /// TODO: make const
- Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
- size_t result, size_t input_rows_count) override = 0;
+ /// Notice: We should not change the column in the block, because the
column may be shared by multiple expressions or exec nodes.
+ virtual Status execute_impl(FunctionContext* context, Block& block,
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status execute_impl(FunctionContext* context, Block& block,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
