github-actions[bot] commented on code in PR #40407: URL: https://github.com/apache/doris/pull/40407#discussion_r1744895959
########## be/src/service/point_query_executor.h: ########## @@ -92,6 +93,9 @@ class Reusable { int64_t mem_size() const; + // delete sign idx in block + int32_t delete_sign_idx() const { return _delete_sign_idx; } Review Comment: warning: function 'delete_sign_idx' should be marked [[nodiscard]] [modernize-use-nodiscard] ```suggestion [[nodiscard]] int32_t delete_sign_idx() const { return _delete_sign_idx; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org