github-actions[bot] commented on code in PR #39828:
URL: https://github.com/apache/doris/pull/39828#discussion_r1741758875


##########
be/src/vec/functions/function_cast.h:
##########
@@ -453,6 +458,12 @@ struct ConvertImpl {
         }
         return Status::OK();
     }
+
+private:
+    static void map_ipv4_to_ipv6(IPv4 ipv4, UInt8* buf) {

Review Comment:
   warning: pointer parameter 'buf' can be pointer to const 
[readability-non-const-parameter]
   
   ```suggestion
       static void map_ipv4_to_ipv6(IPv4 ipv4, const UInt8* buf) {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to