gavinchou commented on code in PR #40226:
URL: https://github.com/apache/doris/pull/40226#discussion_r1741142561
##########
be/src/io/cache/fs_file_cache_storage.cpp:
##########
@@ -172,7 +189,16 @@ Status FSFileCacheStorage::remove(const FileCacheKey& key)
{
std::string dir = get_path_in_local_cache(key.hash,
key.meta.expiration_time);
std::string file = get_path_in_local_cache(dir, key.offset, key.meta.type);
FDCache::instance()->remove_file_reader(std::make_pair(key.hash,
key.offset));
- RETURN_IF_ERROR(fs->delete_file(file));
+ Status s = fs->delete_file(file);
+ if (!s.ok()) {
+ if (key.meta.type == FileCacheType::TTL) {
Review Comment:
this introduces extra IO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
