github-actions[bot] commented on code in PR #40264: URL: https://github.com/apache/doris/pull/40264#discussion_r1740624727
########## be/src/cloud/config.h: ########## @@ -21,10 +21,20 @@ namespace doris::config { -DECLARE_String(cloud_unique_id); +DECLARE_mString(cloud_instance_id); + +DECLARE_mString(cloud_unique_id); static inline bool is_cloud_mode() { - return !cloud_unique_id.empty(); + return !cloud_unique_id.empty() || !cloud_instance_id.empty(); +} + +static inline void set_cloud_unique_id() { Review Comment: warning: unused function 'set_cloud_unique_id' [clang-diagnostic-unused-function] ```cpp static inline void set_cloud_unique_id() { ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org